fix: resolve #472 — add z-index to Drawer root element #473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DarkGenius
requested review from
BlackPoretsky,
Lunory and
kendoow
as code owners
Contributor
|
Preview is ready. |
Contributor
|
Playwright Test Component is ready. |
The Drawer component's root element was missing a z-index, causing it to appear behind elements with even a z-index of 1. This fix adds z-index support to the Drawer root container via the --gn-drawer-z-index CSS variable. Changes: - Added z-index: var(--gn-drawer-z-index) to Drawer root element - Updated README to document the new --gn-drawer-z-index CSS variable - No default value provided to avoid breaking existing layouts - Users can set the CSS variable to control stacking order (e.g., 1000)
DarkGenius
force-pushed
the
fix/issue-472
branch
from
540cb75 to
ad24e58
Compare
Lunory
approved these changes
Oct 9, 2025
kkirik
pushed a commit
that referenced
this pull request
Nov 4, 2025
The Drawer component's root element was missing a z-index, causing it to appear behind elements with even a z-index of 1. This fix adds z-index support to the Drawer root container via the --gn-drawer-z-index CSS variable. Changes: - Added z-index: var(--gn-drawer-z-index) to Drawer root element - Updated README to document the new --gn-drawer-z-index CSS variable - No default value provided to avoid breaking existing layouts - Users can set the CSS variable to control stacking order (e.g., 1000)
DarkGenius
added a commit
that referenced
this pull request
Nov 26, 2025
The Drawer component's root element was missing a z-index, causing it to appear behind elements with even a z-index of 1. This fix adds z-index support to the Drawer root container via the --gn-drawer-z-index CSS variable. Changes: - Added z-index: var(--gn-drawer-z-index) to Drawer root element - Updated README to document the new --gn-drawer-z-index CSS variable - No default value provided to avoid breaking existing layouts - Users can set the CSS variable to control stacking order (e.g., 1000)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #472.
Summary
The Drawer component's root element was missing a z-index, causing it to appear behind elements with z-index: 1 when rendered in a Portal. This PR adds a default z-index of 1000 to the Drawer root container.
Changes
z-index: var(--gn-drawer-z-index, 1000)to Drawer root element inDrawer.scssREADME.mdto document the new--gn-drawer-z-indexCSS variableTesting
This fix ensures the Drawer component properly appears above other page elements, similar to how Modal components behave.